Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dird: console: enable rerun command to work with comma separated list of jobs #1170

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 21, 2022

Description

The rerun command used to process only one jobid. This PR enables the rerun command to handle multiple comma separated jobids at once.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5068-rerun-comma-separated-list-of-jobs branch from cca0a4f to 1ff968f Compare April 21, 2022 16:25
@fbergkemper fbergkemper self-assigned this Apr 25, 2022
Copy link
Contributor

@fbergkemper fbergkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the title of commit e86071d to ua_run.cc: change rerun command to calculate total of days and hours .

Copy link
Contributor

@fbergkemper fbergkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of commit a9d7a6e should mention the introduced or affected component. E.g. gtest: add rerun parse jobid testing or something like that.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5068-rerun-comma-separated-list-of-jobs branch from 1ff968f to 40c5235 Compare April 26, 2022 09:29
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5068-rerun-comma-separated-list-of-jobs branch from 40c5235 to b76026a Compare April 26, 2022 16:05
@fbergkemper fbergkemper self-requested a review April 27, 2022 09:08
Copy link
Contributor

@fbergkemper fbergkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@fbergkemper fbergkemper assigned pstorz and unassigned fbergkemper Apr 27, 2022
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pstorz pstorz merged commit 04e9b7a into bareos:master Apr 27, 2022
@pstorz pstorz deleted the dev/alaaeddineelamri/master/s5068-rerun-comma-separated-list-of-jobs branch April 27, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants