-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dird: console: enable rerun
command to work with comma separated list of jobs
#1170
dird: console: enable rerun
command to work with comma separated list of jobs
#1170
Conversation
cca0a4f
to
1ff968f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the title of commit e86071d to ua_run.cc: change rerun command to calculate total of days and hours
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of commit a9d7a6e should mention the introduced or affected component. E.g. gtest: add rerun parse jobid testing
or something like that.
1ff968f
to
40c5235
Compare
when both `days` and `hours` were specified, the `days` were ignored. Now both are taken into account and summed up
40c5235
to
b76026a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
The
rerun
command used to process only one jobid. This PR enables thererun
command to handle multiple comma separated jobids at once.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testingTests