cats: BareosDb: FilterZeroFileJobs returned list now is sorted #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/another-fix-for-always-incremental-test
branch
2 times, most recently
from
b1c7d6c
to
f2ed2e0
Compare
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/another-fix-for-always-incremental-test
branch
from
f2ed2e0
to
364dd95
Compare
pstorz
requested changes
Apr 27, 2022
There was a problem hiding this comment.
I have the following change requests:
- The PR Name is not meaningful enough, how about
cats: BareosDb::FilterZeroFileJobs returned list now is sortedorsql_get.cc: order zero file jobs by Id - the CHANGELOG.md entry is missing
We probably also want to backport this to 21.
alaaeddineelamri
changed the title
always-incremental-consolidate
Makes systemtest `always-incremental-consolidate` more reliable, as its results can sometimes show a false negative when jobids for zero files are not well ordered
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/master/another-fix-for-always-incremental-test
branch
from
364dd95
to
90060e0
Compare
pstorz
approved these changes
Apr 27, 2022
alaaeddineelamri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR orders zero-file jobids to be purged and makes
always-incremental-consolidatesystemtest more stable.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing