cats: BareosDb: FilterZeroFileJobs returned list now is sorted #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaaeddineelamri
changed the title
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/bareos-21/fix-always-incremental-test
branch
from
a6911da
to
ba7e9f4
Compare
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/bareos-21/fix-always-incremental-test
branch
from
ba7e9f4
to
70f0954
Compare
to `always-incremental-consolidate`
introduced testing function that uses grep to check expected strings in log files (cherry picked from commit f4d68c7)
(cherry picked from commit 974663a)
(cherry picked from commit a1dcca3)
Makes systemtest `always-incremental-consolidate` more reliable, as its results can sometimes show a false negative when jobids for zero files are not well ordered (cherry picked from commit e4c9fdb)
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/bareos-21/fix-always-incremental-test
branch
from
70f0954
to
27bebd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR#1172 to bareos-21
Description
This PR orders zero-file jobids to be purged and makes
always-incremental-consolidatesystemtest more stable.It also adds modifications to the
always-incremental-consolidatethat were not added with previous backports.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing