-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bareos tools: reintegrate testfind binary #1176
bareos tools: reintegrate testfind binary #1176
Conversation
c66ad31
to
af445ca
Compare
d6f6b1b
to
5f45097
Compare
2eed37c
to
a95806b
Compare
a95806b
to
f895291
Compare
f36d2e4
to
9bb1a72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the code with sanitizers, it shows the following:
/core/src/dird/testfind.cc:104:58: runtime error: member call on null pointer of type 'struct ConfigurationParser'
9bb1a72
to
1905681
Compare
7f1c486
to
e22c7dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the systemtest for testfind, an error is reported but still the test passes:
389: Test command: /home/pstorz/git/PR-REVIEW/b/systemtests/tests/testfind/testrunner
389: Test timeout computed to be: 300
389: Expected line "Max path length: 80" was not found in log file "/home/pstorz/git/PR-REVIEW/b/systemtests/tests/testfind/tmp/testfind.out".
389: -->Max path length is incorrect.
1/1 Test #389: system:testfind .................. Passed 0.10 sec
The following tests passed:
system:testfind
100% tests passed, 0 tests failed out of 1
e22c7dc
to
de5f896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please answer the questions that have been asked in the last review.
de5f896
to
b7e30c8
Compare
6e0f45f
to
7d36f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments.
systemtests/tests/testfind/etc/bareos/bareos-sd.d/device/FileStorage.conf
Outdated
Show resolved
Hide resolved
systemtests/tests/testfind/etc/bareos/bareos-fd.d/client/myself.conf.in
Outdated
Show resolved
Hide resolved
7d36f32
to
9080bee
Compare
9080bee
to
51a3844
Compare
5817356
to
e9938e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a typo in commit 224eeff: wirndows
Please fix that one.
Also the CHANGELOG.md entry is not exactly like the PR name is.
CHANGELOG.md
Outdated
@@ -42,6 +42,7 @@ and since Bareos version 20 this project adheres to [Semantic Versioning](https: | |||
- build: Add support for SLE_15_SP4 [PR #1205] | |||
- libcloud plugin: allow to configure the storage provider [PR #1226] | |||
- core/platform: Adding Bareos firewalld service xml files [PR #1237] | |||
- bareos tools: reintegrated testfind binary [PR #1176] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- bareos tools: reintegrated testfind binary [PR #1176] | |
- bareos tools: reintegrate testfind binary [PR #1176] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added the bareos-check-sources changes as one commit
1ff580d
to
098c1ec
Compare
steps: - fixed compile errors and testfind logic. - change order so linking on windows works. - disabled testfind build for client-only. - added testfind binaries to packaging. - fixing build issues for windows and sanitizers.
098c1ec
to
bb3f749
Compare
Description
Reintegrated testfind into the build and fixed logic and compile errors.
Testfind is a tool that uses the same logic used by the file daemon before a backup.
we can use it to benchmark directories/files without launching a backup job.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsgit status
should not report modifications in the source tree after building and testingTests