Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add Security FIPS section #1181

Merged
merged 2 commits into from
Aug 2, 2022
Merged

doc: Add Security FIPS section #1181

merged 2 commits into from
Aug 2, 2022

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented May 11, 2022 •
edited by pstorz
Loading

This PR add a section to explain how to setup and check FIPS enabled computer.
backport should be limited to 21 version as only newer enterprise OS are concerned.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos bruno-at-bareos added requires backport to 21 documentation This PR changes only documentation labels May 11, 2022
@pstorz pstorz requested a review from arogge May 19, 2022 09:15
@pstorz pstorz added the nobuild label May 19, 2022
@arogge arogge self-assigned this Jun 9, 2022
pstorz
pstorz requested changes Jul 28, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move the "MD5 needs to be replaced by SHA256" to the end of the description. When trying to get bareos running on the fips machine, first the openssl needs to be fixed so that the daemons can even communicate, then the MD5 Problem pops up.

docs/manuals/source/TasksAndConcepts/BareosSecurityIssues.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/BareosSecurityIssues.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/BareosSecurityIssues.rst Outdated Show resolved Hide resolved
docs/manuals/source/TasksAndConcepts/BareosSecurityIssues.rst Outdated Show resolved Hide resolved
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-fips-mode-t5015 branch 2 times, most recently from af12dfc to 4194a0c Compare July 28, 2022 11:51
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-fips-mode-t5015 branch from 4194a0c to 8abc63c Compare July 28, 2022 11:56
@pstorz pstorz force-pushed the dev/bruno/master/doc-fips-mode-t5015 branch from 94bc93e to b14e1d5 Compare July 29, 2022 09:53
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-fips-mode-t5015 branch from e475a7f to fe03d84 Compare August 1, 2022 08:16
@pstorz pstorz self-requested a review August 1, 2022 08:49
pstorz
pstorz approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bruno-at-bareos and others added 2 commits August 1, 2022 10:58
@bruno-at-bareos @pstorz
doc: BareosSecurityIssues.rst FIPS
78acb17 
- Add Security FIPS section.

Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
update CHANGELOG.md
2001c01 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-fips-mode-t5015 branch from fe03d84 to 2001c01 Compare August 1, 2022 09:00
@bruno-at-bareos bruno-at-bareos mentioned this pull request Aug 1, 2022
Merged
9 tasks
@bruno-at-bareos bruno-at-bareos assigned pstorz and unassigned arogge Aug 2, 2022
@bruno-at-bareos
Copy link
Contributor Author

@pstorz can this one finished now and merged since approved, also check #1212 backport

pstorz
pstorz approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit 56ffa8c into bareos:master Aug 2, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/doc-fips-mode-t5015 branch August 23, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstorz pstorz pstorz approved these changes

@arogge arogge Awaiting requested review from arogge

Assignees

@pstorz pstorz

Labels
documentation This PR changes only documentation requires backport to 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bruno-at-bareos @pstorz @arogge