Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links with sphinx linkchecker #1200

Merged

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jul 6, 2022

Documentation use sphinx linkcheck to fix broken links

  • Adding linkcheck options to conf.py
  • Fix all broken link in documentation

Sphinx linkcheck can be used during documentation build

sphinx-build -M linkcheck docs/manuals/source docs/BareosMainReference -j2

The automatic usage during documentation build, still need to be discussed.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos bruno-at-bareos added the documentation This PR changes only documentation label Jul 6, 2022
@bruno-at-bareos bruno-at-bareos self-assigned this Jul 6, 2022
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/doc/sphinx_linkchecker branch from a74d114 to 15ca1d4 Compare July 6, 2022 14:03
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/doc/sphinx_linkchecker branch from 15ca1d4 to 8bca558 Compare July 7, 2022 13:34
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very glad you found and configured this tool.
I've suggestions on some of the internal URLs, but besides that, I'm fine with this PR.

bruno-at-bareos and others added 3 commits July 11, 2022 11:41
- Adding linkcheck options to conf.py
- Fix all broken link in documentation
- Increase clarity for Windows download location
- use short url for bareos domain: the redirection is excluded
  as error in linkcheck configuration.
- xca use github devel project

Sphinx linkcheck can be used during documentation build
```sphinx-build -M linkcheck docs/manuals/source docs/BareosMainReference -j2```

Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Use the command

make docs-check-urls

to verify that all used links in the documentation are still valid.
Exceptions can be configured in docs/manuals/source/conf.py

As this command can be time consuming and error prone (due to internet or server problems),
it is not configured to run automatically.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/doc/sphinx_linkchecker branch from 58b4db8 to 6612d70 Compare July 11, 2022 09:44
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@joergsteffens joergsteffens merged commit 9a213c5 into bareos:master Jul 11, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/doc/sphinx_linkchecker branch August 23, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This PR changes only documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants