Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcloud plugin: libcloud storage provider config #1226

Merged
merged 6 commits into from Aug 18, 2022

Conversation

pstorz
Copy link
Member

@pstorz pstorz commented Aug 16, 2022

Is a port of PR #1174 to master

Right now S3 is hardcoded within the provider type
for the apache libcloud plugin. Any other value, in
the config_file parameter for "provider" will not
be respected.

With this change the option will be actually used.

(cherry picked from commit ae36762)

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks contributing.

mat1010 and others added 6 commits August 16, 2022 16:37
Right now S3 is hardcoded within the provider type
for the apache libcloud plugin. Any other value, in
the config_file parameter for "provider" will not
be respected.

With this change the option will be actually used.

(cherry picked from commit ae36762)
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@pstorz pstorz force-pushed the dev/pstorz/master-port-pr-1174 branch from 090d934 to 4a1f372 Compare August 16, 2022 14:37
@pstorz pstorz merged commit a4b6c6d into master Aug 18, 2022
@pstorz pstorz deleted the dev/pstorz/master-port-pr-1174 branch August 18, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants