Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename illegal argument name stdin #123

Closed
wants to merge 6 commits into from
Closed

Rename illegal argument name stdin #123

wants to merge 6 commits into from

Conversation

peter-kutak
Copy link
Contributor

In included <cstdio> is already defined object stdin.
Compilation on Solaris 11.4 fails with c++ (GCC) 7.3.0.

@peter-kutak
repair illegal argument name stdin
2aa33e0 
stdin is already defined in included <cstdio> on Solaris
@peter-kutak
repair illegal argument name stdin
ca9baea 
stdin is already defined in included <cstdio> on Solaris
@peter-kutak
repair illegal argument name stdin
87386ff 
stdin is already defined in included <cstdio> on Solaris
@peter-kutak
Rename round function to roundtoint to avoid conflict with standard c…
9d02b13 
…anditates.
@peter-kutak
Keep option to diasable ACL.
08649fc 
Linking fails on Solaris with ACL enabled.
@peter-kutak
Merge remote-tracking branch 'upstream/master'
4aa6cb1
@franku franku self-assigned this Oct 19, 2018
@franku
Copy link
Contributor

franku commented Oct 19, 2018

Thank you very much for your suggestions. Unfortunately you are mixing some things that do not belong to each other in one PR. However, you already hand in PR 126 and 127 which cover parts of this PR.
Therefore we would like to ask you to provide one PR for each topic that you want to contribute, as you already did in 126 and 127. This way is clearer for us to dedicate answers and responsibilities. As soon as this is done I will close this PR. Thank you again.

franku added a commit that referenced this pull request Oct 30, 2018
@franku
console: changed argument name from stdin to std_in to avoid name con…
6f456aa 
…flicts

- part of pullrequest #123 by peter-kutak
@franku
Copy link
Contributor

franku commented Oct 30, 2018

merged "illegal argument name stdin" into master 6f456aa

@franku
Copy link
Contributor

franku commented Oct 30, 2018

merged "Rename round function to roundtoint to avoid conflict with standard c…" into master by separate pullrequest #127

franku added a commit that referenced this pull request Oct 30, 2018
@franku
console: changed argument name from stdin to std_in to avoid name con…
eaa3cd2 
…flicts

- part of pullrequest #123 by peter-kutak
@franku
Copy link
Contributor

franku commented Apr 25, 2019

Will close this, as there are no new actions for six months now. Anyway most of suggestions have been merged. Thanks again for contribution.

@franku franku closed this Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@franku franku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter-kutak @franku