Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove unused config files #1247

Merged
merged 13 commits into from
Sep 7, 2022
Merged

Conversation

pstorz
Copy link
Member

@pstorz pstorz commented Aug 31, 2022

We have a lot of *-mon conf files in the test directories that are not needed at all. This PR removes them.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

Copy link
Contributor

@alaaeddineelamri alaaeddineelamri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done my review, and everything is ok.
I've removed some more unnecessary config files, so when you have time you can review them too and merge.

@pstorz pstorz changed the title tests: remove all unneeded *-mon.conf* files tests: cleanup config files: removed unused reorganized scheduler test config files Sep 7, 2022
@pstorz pstorz changed the title tests: cleanup config files: removed unused reorganized scheduler test config files tests: remove unused config files Sep 7, 2022
@pstorz pstorz force-pushed the dev/pstorz/master/remove-mon-confs branch from 03ce3cd to 15401dd Compare September 7, 2022 09:57
@pstorz pstorz merged commit a9d0e7a into master Sep 7, 2022
@pstorz pstorz deleted the dev/pstorz/master/remove-mon-confs branch September 7, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants