Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filed: stored: deprecate compatible config option #1284

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Oct 19, 2022

Thank you for contributing to the Bareos Project!

This PR deprecates the compatible configuration option without removing it or modifying the behaviour.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@arogge arogge self-assigned this Oct 19, 2022
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like our versions of clang-format differ on how to format the foreach_alist().
Also, I noticed that neither the FD nor the SD prints the deprecation warning on startup. It does when invoking with -t, but not during normal startup. We may want to figure out why (and if that is a regression in Bareos 22 or not).

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5239-deprecate-compatible branch 3 times, most recently from cad600b to a176b4b Compare October 24, 2022 13:39
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, lacks a CHANGELOG record though.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/s5239-deprecate-compatible branch from a176b4b to 68c36df Compare October 25, 2022 15:39
@arogge arogge merged commit a629773 into bareos:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants