Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui: fix pool link in job details formatter #1303

Merged
merged 2 commits into from
Nov 8, 2022
Merged

webui: fix pool link in job details formatter #1303

merged 2 commits into from
Nov 8, 2022

Conversation

fbergkemper
Copy link
Contributor

@fbergkemper fbergkemper commented Nov 7, 2022 •
edited by bruno-at-bareos
Loading

Backport of PR #1302 to bareos-21

Adds missing query parameter.

Fixes #1489: broken storage pool link

(cherry picked from commit e2fdc8e)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@fbergkemper fbergkemper self-assigned this Nov 7, 2022
bruno-at-bareos
bruno-at-bareos approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and tested.
@pstorz can you also merge this one once green.
@arogge maybe we want this one also in 21.1.5

fbergkemper and others added 2 commits November 7, 2022 17:32
@fbergkemper @bruno-at-bareos
webui: fix pool link in job details formatter
16b2f6e 
Adds missing query parameter.
Update copyright year.

Fixes #1489: broken storage pool link

(cherry picked from commit e2fdc8e)
@bruno-at-bareos
update CHANGELOG.md
8a3192b 
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos
Copy link
Contributor

@arogge for merge

@arogge arogge merged commit 635096a into bareos:bareos-21 Nov 8, 2022
@fbergkemper fbergkemper deleted the dev/fbergkemper/bareos-21/s5306 branch April 21, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@fbergkemper fbergkemper

@arogge arogge

Labels
is a backport to 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbergkemper @bruno-at-bareos @arogge