-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dird: fix for crash when starting rescheduled jobs #1327
dird: fix for crash when starting rescheduled jobs #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you found the fix that quick. Could you please add a short description to when the crash happened.(I.e. what crash is fixed).
This occured with the following config:
and it occured when the job was started at the rescheduled start time. So the description should be: |
0228f1b
to
3a28fb2
Compare
10a6ebb
to
42b68da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment, set -e
is missing in testrunner-reschedule
42b68da
to
74c247e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Thank you for contributing to the Bareos Project!
Description
This PR fixes a crash that occurs when starting rescheduled jobs.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-merge
does not report any problemsTests