Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_cbt_tool.py: pyVmomi 8.x compatibility #1386

Merged

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Feb 20, 2023

This PR backport the fix #da94e4df3 to fix pyVmomi 8.0 compatibility to the tool

It would be great to have both backported to 21.

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)

Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

bruno-at-bareos and others added 2 commits March 1, 2023 10:50
-In pyVmomi 8.0 the SmartConnectNoSSL() method was removed.
 This change uses SmartConnect with the disableSslCertValidation=True
 parameter instead. As it was added in pyVmomi 7.0.2 this is now the
 minimum required version, this was added to the documentation.
 backport of #da94e4df3

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@arogge arogge force-pushed the dev/bruno/fix-vmware_cbt_tool_pyvmomi8x branch from dda746d to f7d2bf1 Compare March 1, 2023 09:50
@arogge arogge merged commit 8e21475 into bareos:master Mar 1, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/fix-vmware_cbt_tool_pyvmomi8x branch March 1, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants