file checksums: add new signature algorithm xxh128 #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arogge
force-pushed
the
dev/arogge/bareos-22/add-xxh128
branch
from
32b7c3b
to
8b1673e
Compare
pstorz
force-pushed
the
dev/arogge/bareos-22/add-xxh128
branch
4 times, most recently
from
e18cbeb
to
8b1673e
Compare
pstorz
force-pushed
the
dev/arogge/bareos-22/add-xxh128
branch
from
ad198c5
to
8b1673e
Compare
As OpenSSL is a hard requirement, these cannot be used anymore and thus will be removed. (cherry picked from commit e97e21d)
Refactor the code on crypto_openssl so that we can add another digest that is not openssl-based. This mostly adds another level of indirection by moving digest update and finalize into class scope and making Digest a base-class with no ties to OpenSSL. TL;DR use virtual dispatch so we can call something that is not OpenSSL (cherry picked from commit 29e6692)
git-subtree-dir: third-party/xxHash git-subtree-split: 35b0373c697b5f160d3db26b1cbb45a0d5ba788c
Add CMake configuration for xxHash library (cherry picked from commit 89089c3)
(cherry picked from commit 414c48e)
Registers the xxHash128 checksum in every place configurable hashes are done. (cherry picked from commit 8801b21)
Change "Signature" in bareos systemtest's fileset to xxh128. (cherry picked from commit d69e476)
Add documentation for the new Signature XXH128 to the FileSet Option documentation. (cherry picked from commit 930785b)
We only want to ignore the files in the third-party subdirectories, not the ones in the toplevel, that we write ourselves. (cherry picked from commit dd35d95)
arogge
force-pushed
the
dev/arogge/bareos-22/add-xxh128
branch
from
8b1673e
to
3eddd5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Backport of PR #1359 to bareos-22
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests