dird: deprecate client Autoprune, JobRetention, and FileRetention

[alaaeddineelamri]

Thank you for contributing to the Bareos Project!

Description

This PR removes client Autoprune, JobRetention, and FileRetention from the client resource in the Director configuration.

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General

• Is the PR title usable as CHANGELOG entry?
• Purpose of the PR is understood
• Commit descriptions are understandable and well formatted
• Check backport line

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR

[sebsura]

There are still references in VolumeManagement.rst.inc; e.g.:

The tools Bareos gives you to help automatically manage these problems are the following:
[File Retention (Dir->Client)]: catalog file record retention period.
[Job Retention (Dir->Client)]: catalog job record retention period.
[Auto Prune (Dir->Client)] = yes: permit the application of the above two retention periods.

Do you think we should get rid of these mentions as well to discourage further use ?

[Ropnuk]

Hello.
how to manage the duration of storage of backups and information about them?
In Dir->pool config? Or another way?
We tried to configure "Auto Prune" parameter in pool config file, but in bconsole I don't see this parameter.

[sebsura]

What did you enter into bconsole and what do you expect it to print ?
And to your question: yes, you should use pool->autoprune for your autopruning needs, see here: https://docs.bareos.org/Configuration/Director.html#config-Dir_Pool_AutoPrune

[sebsura]

The best place to ask questions like these is in the user mailing list; see here https://www.bareos.com/community/join-in/ for details.

[Ropnuk]

In .conf file I see this:

In bconsole I see this

In bconsole there are no information about autoprune parameter.

[arogge]

Pool->AutoPrune is not Client->AutoPrune so this is totally unrelated to this PR.
In other news: Pool->AutoPrune = yes is the default, thus it is omitted on show pool.

[Ropnuk]

I understand.
Thank you for help