Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix schema public with PostgreSQL 15 #1449

Merged

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 17, 2023

In PostgreSQL 15 create/modify right were removed from public schema, making all temp tables creation failing.

  • This PR enables again the create right for the bareos database user.
  • For Debian dbconfig we now use the reassign owned instruction so view and function are also handled correctly.
  • ReadOnly user template is also renewed with schema.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch 2 times, most recently from 9af2c43 to 1fda344 Compare April 20, 2023 13:40
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch 2 times, most recently from 7ba00b5 to e638cc6 Compare May 8, 2023 08:39
@bruno-at-bareos bruno-at-bareos marked this pull request as ready for review May 8, 2023 08:39
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch from e638cc6 to 3660d4c Compare May 8, 2023 12:01
@bruno-at-bareos bruno-at-bareos requested review from pstorz and removed request for arogge May 11, 2023 10:25
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

bruno-at-bareos and others added 3 commits June 1, 2023 14:16
- grant permission on public schema with postgresql>15.
- add views to reassign Debian dbconfig template.
- improve readonly grant sample sql script.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@pstorz pstorz force-pushed the dev/bruno/master/core-fix-postgresql15 branch from 3f7819f to 1971139 Compare June 1, 2023 12:16
@pstorz pstorz merged commit 5b4d804 into bareos:master Jun 1, 2023
@pstorz pstorz mentioned this pull request Jun 9, 2023
7 tasks
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/core-fix-postgresql15 branch June 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants