-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsmtp bls bextract: fixes for command line parsing #1455
bsmtp bls bextract: fixes for command line parsing #1455
Conversation
It is almost working well except if someone use the SMTPSERVER env var with a :PORT
using the var without the port works. I've done this test as if you bsmtp --help indicate this should be possible
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the moment, check my comment about the test with SMTPSERVER:PORT.
The help indicates using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check if we can better handle the default?
Also bsmtp.cc need to have copyright updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--removed--
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Work, I think we can squash the commit concerning bsmtp in one and the second concerning bextract and bls
9009f89
to
e94a854
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!!!
Ready for merge
bsmtp: parse `SMTPSERVER` value bsmtp: update default mailport handling bsmtp: get environment variable earlier renamed `cp` and `mail_port`
9ef9817
to
48ab1d8
Compare
Description
This PR makes sure the
-h
or--mailhost
option is not required and can be left out. It can then be set to theSMTPSERVER
environment variable, or defaultlocalhost
.This PR also include a small fix to handle --include-list (-i) flag in bextract and bls
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality