Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemons: update network handling when IP protocols unavailable #1463

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented May 9, 2023

Thank you for contributing to the Bareos Project!

Backport of PR #1454 to bareos-22

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@pstorz pstorz requested review from sebsura and pstorz and removed request for sebsura May 11, 2023 10:41
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

alaaeddineelamri and others added 14 commits May 12, 2023 10:34
it is used, but the includes within are commented out

(cherry picked from commit b5be8b3)
(cherry picked from commit 3fede59)
(cherry picked from commit 6fbc120)
(cherry picked from commit 0370c22)
replace OSDependentInit with InitDirGlobals
(cherry picked from commit a3928ce)
@pstorz pstorz force-pushed the dev/alaaeddineelamri/bareos-22/disabled-protocol-checks branch from 6e3861a to 859850f Compare May 12, 2023 08:34
@pstorz pstorz merged commit 13ba13f into bareos:bareos-22 May 12, 2023
@pstorz pstorz deleted the dev/alaaeddineelamri/bareos-22/disabled-protocol-checks branch May 12, 2023 08:34
@alaaeddineelamri alaaeddineelamri mentioned this pull request May 23, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants