New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stored: automatically increment tape block size in case the buffer is too small #1496
stored: automatically increment tape block size in case the buffer is too small #1496
Conversation
d5d1fa3
to
ab01b56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; Please check my comment.
@sebsura I implemented what I think the both of us settled on. Would you mind taking another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great. One small detail still needs work.
I think you should mention the build script fix in the PR text itself.
The title should probably prepended by something like stored:
since this mostly effects the storage daemon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
93bd51e
to
833b83b
Compare
dist-tarball.sh was supposed to create "clean" tarballs, that is with a path-prefix of bareos-x.y.z based on the version-number. This didn't happen as rewriting in tar did not take place. With this patch the paths provided to tar are now all prefixed with './' which allows the substitution to work correctly.
when the unix_tape_device encounters a block that is too large for the buffer to handle, it will now re-read with incrementing buffer sizes until it can provide the first part of the block. This allows Bareos to reconfigure the block buffer size for tape devices like it already does for file devices.
When bsr() is called to initiare a re-read on a tape, it will decrement ths block_num. As during the re-read the block_num was not incremented, it shouldn't be decremented.
e3fad2c
to
5b21b2b
Compare
This change allows Bareos to read tape volumes even if the configured
Maximum Block Size
is too small.You will still see an error message like this to notify you that something is not right:
However, restore will not fail anymore.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Check backport lineRequired backport PRs have been createdSource code quality