Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stored: fix incoherent meta data when concurrently writing to the same volume #1514

Merged

Conversation

sebsura
Copy link
Contributor

@sebsura sebsura commented Aug 1, 2023

Thank you for contributing to the Bareos Project!

Backport of PR #1495 to bareos-22

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura force-pushed the dev/ssura/bareos-22/fix-parallel-jobs branch 2 times, most recently from 4733760 to 6c4de16 Compare August 8, 2023 09:51
sebsura and others added 18 commits August 8, 2023 10:26
This does not belong here.  This causes big problems.  The device
might have changed volumes etc. and the values are not related to
anything anymore.  The dcr gets updated after every write so this
is unneccessary as well.

(cherry picked from commit c058e89)
Sometimes we still have some meta data left over after completing a
job.  This ensures that it gets send to the director.

(cherry picked from commit 12162ae)
(cherry picked from commit b0ccce3)
(cherry picked from commit 9942923)
(cherry picked from commit 069f747)
(cherry picked from commit 9516a28)
(cherry picked from commit 07d84a8)
@BareosBot BareosBot force-pushed the dev/ssura/bareos-22/fix-parallel-jobs branch from fa3d6af to 979605c Compare August 8, 2023 10:26
@BareosBot BareosBot merged commit 7badc98 into bareos:bareos-22 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants