Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: switch python-ldap plugin to python3 #1522

Merged
merged 3 commits into from Aug 10, 2023
Merged

plugins: switch python-ldap plugin to python3 #1522

merged 3 commits into from Aug 10, 2023

Conversation

sebastianlederer
Copy link
Collaborator

@sebastianlederer sebastianlederer commented Aug 10, 2023

Port of the python-ldap plugin to Python 3.

Changes are not backward-compatible to Python 2 because of different behaviour of the python-ldap library. Also, Python 2 support will be removed in Bareos 23.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@pstorz pstorz changed the title Dev/sebastianlederer/master/py3 ldap plugin plugins: introduce python3 compatible ldap plugin Aug 10, 2023
@pstorz pstorz changed the title plugins: introduce python3 compatible ldap plugin plugins: port python-ldap plugin to python3 Aug 10, 2023
@joergsteffens joergsteffens changed the title plugins: port python-ldap plugin to python3 plugins: switch python-ldap plugin to python3 Aug 10, 2023
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Sebastian Lederer and others added 3 commits August 10, 2023 20:36
Adjust to different behaviour of python-ldap in Python 3,
cleanup constants, remove unused code.
@BareosBot BareosBot merged commit 9e08434 into bareos:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants