require TLS by default #1529
Merged
require TLS by default #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
force-pushed
the
dev/pstorz/master/tls-require-yes-default
branch
2 times, most recently
from
ea2f45a
to
61667e0
Compare
|
Upstream Python is maybe making effort in having finally TLS-PSK supported in native ssl module |
pstorz
commented
Sep 18, 2023
arogge
reviewed
Sep 20, 2023
| @@ -40,7 +40,7 @@ messages | |||
| list jobs | |||
| @$out $log_home/should-hang.out | |||
| restore client=bareos-fd fileset=SelfTest where=$tmp/bareos-restores select all done yes | |||
| @sleep 3 | |||
| @sleep 10 | |||
There was a problem hiding this comment.
do we really need to wait for 10 seconds here?
arogge
changed the title
arogge
force-pushed
the
dev/pstorz/master/tls-require-yes-default
branch
from
52d5254
to
65b2001
Compare
arogge
approved these changes
Sep 22, 2023
As the default now is `TlsRequire = Yes`, this commit sets TlsRequire to No in the configuration files for this test.
As Tls Require now defaults to yes, we need to set it to no to make the test work.
Previously, when setting `TLS Require = yes` this would implicitly also set `TLS Enable = yes`. Since both, `TLS Enable` and `TLS Require` now default to yes, this would mean that to disable TLS you have to set both `TLS Enable = no` and `TLS Require = no`. Thus patch changes the behaviour, to make `TLS Enable = no` also imply `TLS Require = no`. The most common scenarios don't require any configuration change, as the effect is unchanged. In the improbable case where you had configured Bareos like this: ``` TLS Enable = no TLS Require = yes ``` The old behaviour was to have TLS enabled and required, while the new behaviour is now to have TLS disabled.
BareosBot
force-pushed
the
dev/pstorz/master/tls-require-yes-default
branch
from
59900e4
to
9e66fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests