New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMware Plugin: Fix transformer issues #1555
Merged
BareosBot
merged 6 commits into
bareos:bareos-22
from
pstorz:dev/pstorz/bareos-22/backport-of-1532
Sep 19, 2023
Merged
VMware Plugin: Fix transformer issues #1555
BareosBot
merged 6 commits into
bareos:bareos-22
from
pstorz:dev/pstorz/bareos-22/backport-of-1532
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstorz
force-pushed
the
dev/pstorz/bareos-22/backport-of-1532
branch
from
September 15, 2023 06:58
6e2d6a2
to
67eb002
Compare
sduehr
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
The VMware Plugin can now recreate virtual machines which use VirtualPCIPassthrough or VirtualEnsoniq1371. Backup now terminates without warning in this case. Additionally, the vmware_cbt_tool.py can now dump the virtual machine config metadat to a JSON file, this can be helpful to debug issues with metadata transformation to recreate virtual machines. (cherry picked from commit 9b9d3d1)
The above properties can be missing, the plugin code now handles this properly so that backup jobs no longer cause false warnings. (cherry picked from commit 9121c97)
The object_index of restore objects must always increase globally, not only within a job, because the SQL query uses ORDER BY ObjectIndex only. Otherwise restore objects could be processed in wrong order. (cherry picked from commit 393877f)
Unified setting controllerKey and unitNumber. Note in docs properly formatted now. (cherry picked from commit d1e7ff8)
(cherry picked from commit 8c486e3)
BareosBot
force-pushed
the
dev/pstorz/bareos-22/backport-of-1532
branch
from
September 19, 2023 20:45
1c37ab1
to
510a42c
Compare
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 11, 2023
Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 12, 2023
Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit f9d64a9)
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 12, 2023
- Remove dependency to libmod-php Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit f9d64a9)
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 12, 2023
- remove libapache2-mod-fcgid Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 12, 2023
- remove libapache2-mod-fcgid Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 0a24982)
bruno-at-bareos
added a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 12, 2023
- remove libapache2-mod-fcgid - remove libapache2-mod-php Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 0a24982)
BareosBot
pushed a commit
to bruno-at-bareos/bareos
that referenced
this pull request
Oct 16, 2023
- remove libapache2-mod-fcgid Fixes bareos#1555: bareos-webui depends needlessly on libapache2-mod-fcgid Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 0a24982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Backport of PR #1532 to bareos-22
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality