Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemons: set CLI11 error exit code to 41 and bareos config parsing error exit code to 42 #1557

Conversation

alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Sep 18, 2023

Backport of PR #1515 to bareos-22

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/bareos-22/update-exit-codes branch 2 times, most recently from 10c38d0 to 7f97ccb Compare September 20, 2023 13:39
@pstorz pstorz self-requested a review September 25, 2023 09:47
core/src/tests/sd_reservation.cc Show resolved Hide resolved
@pstorz pstorz force-pushed the dev/alaaeddineelamri/bareos-22/update-exit-codes branch from b061f7a to 07da0a1 Compare September 25, 2023 15:38
alaaeddineelamri and others added 11 commits September 25, 2023 17:26
- add After=local-fs.target
- place StartLimitBurst=10 in service part instead unit
- replace generic exit 1 by the specific configuration error 
exit code 42  and wrong command line parameter 41
- add comment about how to reset failed counter
- reformat debian filedaemon service file

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit 293a8f8)
(cherry picked from commit 33cb873)
@BareosBot BareosBot force-pushed the dev/alaaeddineelamri/bareos-22/update-exit-codes branch from e10b5df to 205185b Compare September 25, 2023 17:26
@BareosBot BareosBot merged commit c544d1a into bareos:bareos-22 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants