New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemons: set CLI11 error exit code to 41
and bareos config parsing error exit code to 42
#1557
Merged
BareosBot
merged 11 commits into
bareos:bareos-22
from
alaaeddineelamri:dev/alaaeddineelamri/bareos-22/update-exit-codes
Sep 25, 2023
Merged
daemons: set CLI11 error exit code to 41
and bareos config parsing error exit code to 42
#1557
BareosBot
merged 11 commits into
bareos:bareos-22
from
alaaeddineelamri:dev/alaaeddineelamri/bareos-22/update-exit-codes
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaaeddineelamri
force-pushed
the
dev/alaaeddineelamri/bareos-22/update-exit-codes
branch
2 times, most recently
from
September 20, 2023 13:39
10c38d0
to
7f97ccb
Compare
pstorz
approved these changes
Sep 25, 2023
pstorz
force-pushed
the
dev/alaaeddineelamri/bareos-22/update-exit-codes
branch
from
September 25, 2023 15:38
b061f7a
to
07da0a1
Compare
(cherry picked from commit 8d07105)
(cherry picked from commit ffbdd79)
(cherry picked from commit 67a934c)
- add After=local-fs.target - place StartLimitBurst=10 in service part instead unit - replace generic exit 1 by the specific configuration error exit code 42 and wrong command line parameter 41 - add comment about how to reset failed counter - reformat debian filedaemon service file Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 293a8f8)
(cherry picked from commit 33cb873)
(cherry picked from commit f126bb5)
(cherry picked from commit 17b1300)
(cherry picked from commit eba054a)
BareosBot
force-pushed
the
dev/alaaeddineelamri/bareos-22/update-exit-codes
branch
from
September 25, 2023 17:26
e10b5df
to
205185b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1515 to bareos-22
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests