Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware Plugin: Fix backup and recreating VMs with PCI passthrough for GPU #1565

Merged
merged 5 commits into from Oct 6, 2023
Merged

VMware Plugin: Fix backup and recreating VMs with PCI passthrough for GPU #1565

merged 5 commits into from Oct 6, 2023

Conversation

sduehr
Copy link
Member

@sduehr sduehr commented Sep 25, 2023 •
edited by pstorz

The Bareos VMware plugin can now backup an recreate VMs which have a virtual PCI passthrough for GPU configured.
Additionally, the plugin can now try to enable CBT by setting the new plugin option enable_cbt=yes.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@pstorz pstorz self-requested a review September 28, 2023 10:16
@pstorz pstorz self-assigned this Sep 28, 2023
@pstorz pstorz mentioned this pull request Oct 5, 2023
Merged
12 tasks
pstorz
pstorz requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the documentation writes CBT, we should also use that in the error messages.

core/src/plugins/filed/python/vmware/BareosFdPluginVMware.py Outdated Show resolved Hide resolved
core/src/plugins/filed/python/vmware/BareosFdPluginVMware.py Outdated Show resolved Hide resolved
@sduehr sduehr requested a review from pstorz October 6, 2023 17:56
pstorz
pstorz approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

sduehr and others added 5 commits October 6, 2023 19:36
@sduehr @BareosBot
VMware Plugin: Fix transform GPU PCI passthrough
9971051 
Proper handling of GPU PCI passthrough for recreating such VMs.
The VmiopBackingInfo is now processed correctly. New properties
that were added in vSphere 8 are detected.
@sduehr @BareosBot
VMware Plugin: Add option to enable CBT
4549b97 
Add the plugin option enable_cbt, when set set to yes, the plugin
will enable CBT if possible and it is not yet enabled.
@sduehr @BareosBot
docs: VMware Plugin option enable_cbt
ee0074f 
Documention for the VMware Plugin option enable_cbt.
@sduehr @pstorz @BareosBot
Apply suggestions from code review
5750e01 
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
@BareosBot
Update CHANGELOG.md
83d2a8f
@BareosBot BareosBot force-pushed the dev/sduehr/master/vmware-fix-vmiopbackinginfo branch from aa395c1 to 83d2a8f Compare October 6, 2023 19:36
@BareosBot BareosBot merged commit 5093c91 into master Oct 6, 2023
@BareosBot BareosBot deleted the dev/sduehr/master/vmware-fix-vmiopbackinginfo branch October 6, 2023 19:36
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Nov 22, 2023
@joergsteffens
macos: add missing library
6147b21 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Nov 30, 2023
@joergsteffens
macos: add missing library
dc74d09 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 1, 2023
@joergsteffens
macos: add missing library
9ec21ca 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 3, 2023
@joergsteffens
macos: add missing library
14d4b47 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 3, 2023
@joergsteffens
macos: add missing library
79d14c6 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 11, 2023
@joergsteffens
macos: add missing library
41f9946 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma

(cherry picked from commit 79d14c6)
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 11, 2023
@joergsteffens
macos: add missing library
83503c8 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma

(cherry picked from commit 79d14c6)
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Dec 11, 2023
@joergsteffens
macos: add missing library
f495a6d 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma

(cherry picked from commit 79d14c6)
arogge pushed a commit to joergsteffens/bareos that referenced this pull request Dec 12, 2023
@joergsteffens @arogge
macos: add missing library
73a3ec4 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
arogge pushed a commit to joergsteffens/bareos that referenced this pull request Dec 12, 2023
@joergsteffens @arogge
macos: add missing library
dd65e9a 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma

(cherry picked from commit 79d14c6)
bruno-at-bareos pushed a commit to pstorz/bareos that referenced this pull request Dec 12, 2023
@joergsteffens @bruno-at-bareos
macos: add missing library
6374ef3 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
bruno-at-bareos pushed a commit to sebsura/bareos that referenced this pull request Jan 10, 2024
@joergsteffens @bruno-at-bareos
macos: add missing library
ff12596 
required for macOS >= 14.

Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma

(cherry picked from commit 79d14c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels
bugfix requires backport to 22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sduehr @pstorz @BareosBot