docs: improvements for droplet, jobdefs #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-bareos
force-pushed
the
dev/bruno/master/doc-fix-droplet-comments
branch
from
cca1320
to
1a1ac00
Compare
bruno-at-bareos
force-pushed
the
dev/bruno/master/doc-fix-droplet-comments
branch
3 times, most recently
from
7fc5a52
to
a90f5c3
Compare
- remove comment from .profile example - add limitation section about comments in profile - add limitation section about the 9999 limit of chunks Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- Ease life of user, by allowing several restores to run concurrently. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
force-pushed
the
dev/bruno/master/doc-fix-droplet-comments
branch
from
441065a
to
61d95cd
Compare
- inform users about the need to override default 1 if they want concurrent migrate/copy jobs Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos
force-pushed
the
dev/bruno/master/doc-fix-droplet-comments
branch
from
61d95cd
to
ea0d3eb
Compare
sduehr
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Thanks, looks good so far, just suggested some small changes.
Also noticed that MaximumWorkersPerJob was added but without description.
And TlsCipherSuites is not mentioned in TransportEncryption.rst. If these two are not yet already covered in other PRs, we may want to add Tasks for that.
docs/manuals/source/manually_added_config_directive_descriptions/dir-job-JobDefs.rst.inc
Outdated
Show resolved
Hide resolved
Co-authored-by: sduehr <stephan.duehr@bareos.com>
|
Thanks, looks good now, ready for approval, the only thing missing is the backport to 23. |
10 tasks
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr aims to improve part of the documentation:
OP#5484
OP#5227
OP#5610
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality