Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: force cd / for all PostgreSQL scripts #1607

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Nov 28, 2023

add a forced cd / in scripts headers, with an explicit comment.

PostgreSQL binaries tried to chdir() at the end.
we force them to start somewhere postgres user will be able to return without permissions errors.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

pstorz
pstorz previously requested changes Nov 29, 2023
core/src/cats/create_bareos_database.in Outdated Show resolved Hide resolved
@arogge arogge dismissed pstorz’s stale review December 8, 2023 13:17

required changes have been addressed

bruno-at-bareos and others added 4 commits December 8, 2023 13:59
add a forced cd / in scripts headers, with an explicit comment.

PostgreSQL binaries tried to chdir() at the end.
we force them to start somewhere postgres user will be able
to return without permissions errors.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-postgresql-scripts-root-dir branch from 7abfaab to c7313f7 Compare December 8, 2023 13:59
@BareosBot BareosBot merged commit d7c4ccd into bareos:master Dec 8, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-postgresql-scripts-root-dir branch January 15, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants