Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filedaemon: remove ovirt plugin #1617

Merged
merged 5 commits into from Dec 12, 2023

Conversation

pstorz
Copy link
Member

@pstorz pstorz commented Dec 7, 2023

Thank you for contributing to the Bareos Project!

This PR removes the oVirt plugin.

Bareos dropped the support for Python 2, and the oVirt Plugin does not work stable on Python 3.

As Red Hat already has announced that Red Hat Virtualization will be
discontinued and customers should merge away, the Bareos project will not
work on solving the problems with Python 3 which are caused by third-party
python modules.

If you are using the oVirt plugin, stay with Baros 22 using the Python 2
Version of the plugin.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to propose to remove the rest of the documentation chapter, especially for 24,23 so people going to look for a detail will see that it doesn't exist anymore.

We can backport to 22 the warning section. and as you wish keep just that warning in 23 documentation and remove everything in master.

We will keep the o-virt filter in the subscription view for still a few version, as it may help to determined usage of obsolete plugins.

To be checked in core/cmake/BareosInstallConfigFiles.cmake:153 there's a mention of o-virt.

@bruno-at-bareos bruno-at-bareos force-pushed the dev/pstorz/master/remove-ovirt-plugin branch from 5235fbb to 4d34584 Compare December 12, 2023 12:11
@BareosBot BareosBot force-pushed the dev/pstorz/master/remove-ovirt-plugin branch from c1aa64e to 1d8535c Compare December 12, 2023 15:11
@BareosBot BareosBot merged commit a609be0 into bareos:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants