stored: don't touch devices that were not acquired #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when one of acquire_device_for_read() or acquire_device_for_append() in do_mac_run() returned false, the code still touched the devices eventually failing another job that had the device currently acquired. This patch makes sure do_mac_run() does not touch any device it couldn't aquire.
|
Can someone please take a really good look at this? I cannot write a test as reservation usually handles this and it breaks only sometimes under high load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when one of acquire_device_for_read() or
acquire_device_for_append() in do_mac_run()
returned false, the code still touched the
devices eventually failing another job that
had the device currently acquired.
This patch makes sure do_mac_run() does not
touch any device it couldn't aquire.