Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FreeBSD build #1645

Conversation

arogge
Copy link
Member

@arogge arogge commented Dec 22, 2023

Thank you for contributing to the Bareos Project!

Backport of PR #1538 to bareos-21

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@arogge arogge force-pushed the backport/bareos-21/freebsd-python-version-independent branch 2 times, most recently from 967a570 to 1bde8d1 Compare January 9, 2024 11:05
@arogge arogge force-pushed the backport/bareos-21/freebsd-python-version-independent branch from 1bde8d1 to fba3a9f Compare January 10, 2024 09:53
@sebsura sebsura self-requested a review January 11, 2024 06:32
@sebsura sebsura self-assigned this Jan 11, 2024
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

pstorz and others added 9 commits January 11, 2024 09:54
(cherry picked from commit 51e9f5d)
(cherry picked from commit 0e8c0b8)
(cherry picked from commit 89f85ce455df33c673a32c95d09666f656c4d984)
@arogge arogge force-pushed the backport/bareos-21/freebsd-python-version-independent branch from fba3a9f to 47f3ee3 Compare January 11, 2024 08:55
@BareosBot BareosBot merged commit e248504 into bareos:bareos-21 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants