Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: sql_* add leading space to sql construct #1656

Merged
merged 2 commits into from
Jan 11, 2024
Merged

core: sql_* add leading space to sql construct #1656

merged 2 commits into from
Jan 11, 2024

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jan 9, 2024 •
edited by sebsura

This PR aims to:

  • fix ERROR: trailing junk after numeric literal at or near "123A" in sql_list.cc
  • Add IF EXISTS in DROP TABLE statement
  • unifomize the query in sql_upgrade.cc
  • control all sql function for missing space

OP#5667

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura sebsura self-requested a review January 10, 2024 09:51
@sebsura sebsura self-assigned this Jan 10, 2024
sebsura
sebsura requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

core/src/cats/bvfs.cc Show resolved Hide resolved
This was referenced Jan 10, 2024
Merged
Merged
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-sql_list.cc-missing-space branch from cff5155 to 762673d Compare January 11, 2024 08:59
sebsura
sebsura approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

bruno-at-bareos and others added 2 commits January 11, 2024 11:10
@bruno-at-bareos @BareosBot
core: sql_* add leading space to sql construct
ea8c14f 
- fix ERROR: trailing junk after numeric literal at or near "123A"
  in sql_list.cc
- Add IF EXISTS in DROP TABLE statement
- unifomize the query in sql_upgrade.cc
- control all sql function for missing space

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot
Update CHANGELOG.md
36a330d
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-sql_list.cc-missing-space branch from f8f3784 to 36a330d Compare January 11, 2024 11:10
@BareosBot BareosBot merged commit a15e7c4 into bareos:master Jan 11, 2024
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-sql_list.cc-missing-space branch January 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsura sebsura sebsura approved these changes

Assignees

@sebsura sebsura

Labels
requires backport to 22 requires backport to 23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bruno-at-bareos @sebsura @BareosBot