-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: cleanup #1661
cmake: cleanup #1661
Conversation
9cb7f7b
to
10f3235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall. I have a few questions and I think you should check if it makes sense to mark some of the cache variables as advanced, so they're hidden from the default-view in ccmake.
@arogge I applied your suggestion and also mark some of the variables as advanced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking that long. This looks really, really good!
std::find_if is sometimes declared as [[nodiscard]]. As such we should not ignore its return value. This commit also slightly refactors the code to remove the use of std::find_if alltogether.
is_reloading can written to/ read from multiple different threads at the same time. As such we cannot just do a test-then-set approach (even if each of those operations were atomic). Instead we need to atomically test _and_ set the flag to actually prevent two different threads from entering.
The base config path may change on a reload!
exec_program is deprecated since cmake >= 3.0
The travis service is no longer used, therefore these files are no longer required.
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
Mark option, that are normally not manually set as advanced.
Some option are ON by default. This change marks them as advanced and removes them from the build descriptions.
0e8aa97
to
27ec66c
Compare
Thank you for contributing to the Bareos Project!
During PR #1592 it turns out that a number of cmake config settings could be cleaner,
especially when it comes to macOS configuration.
Instead of integrating this in the bugfixing PR, this is now handled in this separate PR.
This PR replaces #1610, as only a PR in https://github.com/bareos/bareos can be used to test the new macOS build workflow handling.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
.github/workflows/build-macos.yml
available in bareos-23 (yes), bareos-22 (macOS build workflow (for Bareos-22) #1691) and bareos-21 (macOS build workflow #1692)?Source code quality