plugins: postgresql fix missing pg_backup_stop() call #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-bareos
force-pushed
the
backport/bareos-23/plugin-postgresql-fix-incrementals
branch
from
fce655d
to
e10bb90
Compare
- pg_backup_stop() is called in all job level depending of the `backup_running` status. This allow a better support of incremental with no changes. - add in testrunner-default checks of WARNING or ERROR in cluster logs - is_backup_running boolean true if pg_backup_start has been run - is_backup_full boolean true if backup level is Full - apply black formatting suggestion Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on the database server Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit b5f2eb1)
BareosBot
force-pushed
the
backport/bareos-23/plugin-postgresql-fix-incrementals
branch
from
6d89219
to
0f3a5c8
Compare
bruno-at-bareos
deleted the
backport/bareos-23/plugin-postgresql-fix-incrementals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1655 to bareos-23
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.Source code quality (if there were changes to the original PR)