filed: fix vss during client initiated connections #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsura
force-pushed
the
dev/ssura/master/fix-client-connected-vss
branch
2 times, most recently
from
8491f84
to
5251048
Compare
pstorz
requested changes
Jan 19, 2024
sebsura
force-pushed
the
dev/ssura/master/fix-client-connected-vss
branch
from
5251048
to
0ce992a
Compare
9 tasks
sebsura
force-pushed
the
dev/ssura/master/fix-client-connected-vss
branch
from
0ce992a
to
dc578f0
Compare
9 tasks
9 tasks
sebsura
force-pushed
the
dev/ssura/master/fix-client-connected-vss
branch
from
dc578f0
to
4484237
Compare
Now the error number is always printed and trailing whitespace is trimmed.
When using client initiated connection we do not call the normal procedure but instead directly call process_director_commands. This caused us to not correctly initialise the threadspecific jcr, which is used in 1) debug messages and 2) for vss name lookup This caused us to print bad jobids in debug messages as well as not using the vss system at all.
jobids are 32bit, but are printed as 64bit -> bad things happens on windows.
BareosBot
force-pushed
the
dev/ssura/master/fix-client-connected-vss
branch
from
66c0cc2
to
98a50b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Using client initiated connections lead to the filedaemon trying to open files on the live system and not on the shadow copy. This was caused by not setting up the thread local jcr pointer correctly. This pr fixes that issue.
It also includes:
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality