Improve FreeBSD dependencies #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2024
pstorz
approved these changes
Jan 26, 2024
USES+=pgsql will pin us to a specific version of PostgreSQL, which is probably not a great idea, so we remove it. This will retain the (automatic) requirement to libpq, so a compatible postgresql client will be required by the binary package.
as we already have openssl in base, it is probably easier to just use that one instead of the one from ports.
BareosBot
force-pushed
the
dev/arogge/master/freebsd-dependencies
branch
from
540ad11
to
41c5434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the existing FreeBSD dependencies.
Remove USES=pgsql
An explicit dependency on pgsql would make the resulting packages require the exact PostgreSQL version that was used during the build. As we only really require the library and a few tool to be present, the library dependency seems to be sufficient.
So now the use can finally use any PostgreSQL version from ports with Bareos.
Remove DEFAULT_VERSIONS+=ssl=openssl
Previously we forced using openssl from ports. As OpenSSL is already in base it should be possible to build against that (which our binary packages will do in the future) while still retaining support for custom builds with OpenSSL from ports.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality