Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bareos-config: fix output of deploy_config #1672

Merged
merged 2 commits into from Jan 22, 2024

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Jan 22, 2024

Replacing the initial variables have been to noisy, especially newly generated passwords have also be printed.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Replacing the initial variables have been to noisy,
especially newly generated passwords have also be printed.
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and improvement.
Tested and Approved.
Please create the backport, once done check the last check mark.

@BareosBot BareosBot merged commit cdbf6e2 into bareos:master Jan 22, 2024
@joergsteffens joergsteffens deleted the dev/joergs/master/postinst branch January 22, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants