Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-bareos: integrate usage of config files #1678

Merged
merged 7 commits into from Jan 30, 2024
Merged

python-bareos: integrate usage of config files #1678

merged 7 commits into from Jan 30, 2024

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Jan 23, 2024 •
edited by bruno-at-bareos

Extends python-bareos to retrieve its parameter via config file.
It does so, by replacing argparse by configargparse.
Because configargparse is not available as package on all platforms,
it still falls back to argparse.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
  • https://git.bareos.com/bareos/CD/pulls/65 is merged
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 38719c0 to 12bf70e Compare January 23, 2024 14:43
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 51e4ec1 to 7b4ccc1 Compare January 25, 2024 12:48
@joergsteffens joergsteffens marked this pull request as ready for review January 25, 2024 12:49
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 7b4ccc1 to d2ae948 Compare January 26, 2024 11:00
bruno-at-bareos
bruno-at-bareos requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be a nice improvement. See comments for changes.

python-bareos/bareos/util/argparse.py Outdated Show resolved Hide resolved
python-bareos/bin/bareos-fd-connect.py Outdated Show resolved Hide resolved
python-bareos/bin/bareos-jsonrpc-server.py Outdated Show resolved Hide resolved
python-bareos/bin/bconsole-json.py Outdated Show resolved Hide resolved
python-bareos/bin/bconsole.py Outdated Show resolved Hide resolved
contrib/misc/bareos_pam_integration/pam_exec_add_bareos_user.py Outdated Show resolved Hide resolved
contrib/misc/triggerjob/bareos-triggerjob.py Outdated Show resolved Hide resolved
python-bareos/bin/bareos-jsonrpc-server.py Outdated Show resolved Hide resolved
python-bareos/bin/bconsole-json.py Outdated Show resolved Hide resolved
python-bareos/bin/bconsole.py Outdated Show resolved Hide resolved
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 32b7365 to 0640b6a Compare January 29, 2024 13:25
@joergsteffens
python-bareos: use configargparse
c2874a4 
instead of argparse.
@joergsteffens
python-bareos: disable Python 2 packages
e7f0300 
Python 2 is no longer supported.
Also the python-bareos packages for Debian >= 12 and Ubuntu 22.04 have
been created without content.
@joergsteffens
python-bareos: requires from 2.7 to 3.6 (RHEL7)
ec48c87
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 0640b6a to 8fedbed Compare January 29, 2024 13:57
bruno-at-bareos and others added 3 commits January 29, 2024 14:58
@bruno-at-bareos @joergsteffens
systemtests: PostgreSQL setup_local_db.sh add root db
dfbd8b3 
Create also the root database in case of tests in podman rootless

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@joergsteffens @bruno-at-bareos
python-bareos: changes from code-review
2872733 
Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
@joergsteffens
python-bareos: pylint suggested changes
b677221
@joergsteffens joergsteffens force-pushed the dev/joergs/master/python-ConfigArgParse branch from 8fedbed to b677221 Compare January 29, 2024 13:59
bruno-at-bareos
bruno-at-bareos approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this excellent improvement.

@joergsteffens joergsteffens mentioned this pull request Jan 30, 2024
Merged
6 tasks
@BareosBot BareosBot merged commit 31a8fc2 into bareos:master Jan 30, 2024
@joergsteffens joergsteffens deleted the dev/joergs/master/python-ConfigArgParse branch April 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels
requires backport to 23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joergsteffens @bruno-at-bareos @BareosBot