Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Pool explanation for migration jobs #1728

Merged

Conversation

sebastianlederer
Copy link
Collaborator

@sebastianlederer sebastianlederer commented Mar 6, 2024

  • correctly describe the effect of the Pool statement for Copy and Migration jobs in case of "SQL Query" selection type
  • fix example configuration

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos self-requested a review March 7, 2024 09:41
@bruno-at-bareos bruno-at-bareos self-assigned this Mar 7, 2024
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that part of the manual.
I'm proposing those wording changes. feel free to accept or adapt.

@bruno-at-bareos
Copy link
Contributor

@sebastianlederer don't forget to also apply bareos-check-sources
pr tool is complaining on

bareos-check-sources --since=48271b59f9cadb2e77de2b87903e3f8e9ed03a24 reported:

[2024-03-12T14:35:13.879Z] 	Plugin 'trailing newlines' would modify 'docs/manuals/source/manually_added_config_directive_descriptions/dir-job-SelectionPattern.rst.inc'

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a great improvement for our users.

Sebastian Lederer and others added 3 commits March 13, 2024 15:01
- describe the effect of the Pool statement for Copy and Migration jobs
  correctly in case of "SQL Query" selection type
- fix example configuration
@BareosBot BareosBot force-pushed the dev/slederer/docfix-copyjobs branch from 9445cfc to 6cf7fe2 Compare March 13, 2024 15:01
@BareosBot BareosBot merged commit 258f0b6 into bareos:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This PR changes only documentation requires backport to 23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants