New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate LICENSE.txt from LICENSE.template #1753
Generate LICENSE.txt from LICENSE.template #1753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
- There's a fix for ./core/src/win32/plugins/filed/mssqlvdi-fd.cc instead of .c
- A control to see why it would be mandatory to have it included in exception as it is AGPL.
- We need to decide if we want this as LICENSE.txt in github root folder and then use that one for packaging.
d37c970
to
ba432de
Compare
We may want to sort out the building of LICENSE.txt in root related to #1755 |
As discussed during the meeting, we would like to have this Makefile able to build /LICENSE.txt file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is ok now, could you handle the /LICENSE.txt generation?
As discussed in the DevMeeting, I'll do a rework and create the LICENSE.txt file. |
183fda8
to
13e21fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, we're almost done.
Please check my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the removal of the cmake target, the README.md in third party need to be fixed. See suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks nice improvement.
9930fd0
to
535874d
Compare
Fix adding webui/copyright, remove unimportant sections, update to 2024.
Create LICENSE.txt by calling devtools/update-license-file.sh which merges LICENSE.template and core/LICENSE. core/LICENSE covers the code in core/ and stays unchanged, at it has been setup with legal help. Before there has been a mechanism to update debian/copyright. Now debian/copyright is just a link to LICENSE.txt, which is formated according to https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
... as this third-party library is alredy covered in LICENSE.txt
by calling: devtools/update-license-file.sh
Moved file from core/cmake to cmake, as it is not specific for core.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
3385f86
to
cf0a2ee
Compare
Moved away from generating
debian/copyright
and createLICENSE.txt
instead.Fix adding
webui/copyright
, remove unimportant sections, update to 2024.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality