Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-tool: give hint about commit headline length limits #1763

Merged

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Apr 4, 2024

Thank you for contributing to the Bareos Project!

I already wondered several times, about how long headline could be. Changed the code to give a hint. Decided not to mention the 50, to keep the remark as short as possible.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@joergsteffens joergsteffens changed the title pr-tool: give hint about commit headline lenghts limits pr-tool: give hint about commit headline lenght limits Apr 4, 2024
@joergsteffens joergsteffens force-pushed the dev/joergs/master/pr-tool-headline branch from 6231e29 to 1899463 Compare April 4, 2024 10:24
@joergsteffens joergsteffens marked this pull request as ready for review April 4, 2024 10:24
@sebsura sebsura changed the title pr-tool: give hint about commit headline lenght limits pr-tool: give hint about commit headline length limits Apr 8, 2024
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@sebsura
Copy link
Contributor

sebsura commented Apr 8, 2024

Could you fix the type in the first commit headline ? lenght -> length

@joergsteffens joergsteffens force-pushed the dev/joergs/master/pr-tool-headline branch from 62ecc6b to 1ae9e8a Compare April 8, 2024 12:38
@joergsteffens
Copy link
Member Author

Fixed type and squashed commits.

@BareosBot BareosBot force-pushed the dev/joergs/master/pr-tool-headline branch from e1f928e to 9cbf954 Compare April 11, 2024 07:16
@BareosBot BareosBot merged commit 003af07 into bareos:master Apr 11, 2024
@joergsteffens joergsteffens deleted the dev/joergs/master/pr-tool-headline branch April 15, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants