Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats: fix subscription view missing mariabackup plugin #1767

Merged

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 10, 2024

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos added this to the 24.0.0 milestone Apr 10, 2024
@bruno-at-bareos bruno-at-bareos self-assigned this Apr 10, 2024
@arogge arogge requested a review from sebsura April 16, 2024 09:57
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

core/src/cats/ddl/updates/postgresql.2230_2240.sql Outdated Show resolved Hide resolved
core/src/cats/ddl/creates/postgresql.sql Show resolved Hide resolved
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work!

bruno-at-bareos and others added 4 commits April 29, 2024 05:19
- add missing mariabackup plugin
- increase catalog version to 2240

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
With commit 452a8a4 file_jobid_idx was removed and replaced,
but the update version script forget to drop it if it exists.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- add comment to explain the index drop
- fix version used in headline

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants