-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr-tool: update LICENSE.txt #1773
pr-tool: update LICENSE.txt #1773
Conversation
fd2aadd
to
b4b0bb6
Compare
b4b0bb6
to
f7b5eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor issues with the copyright headers.
Besides that there is a small performance gain possible by omitting an API request and pylint brought up a few remarks.
I just discovered. that github now has 2 License entries. I assume, one for LICENSE.txt and on for LICENSE.template (https://github.com/bareos/bareos?tab=License-2-ov-file). |
a43dcfa
to
9481e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Sorry for taking so long to finally review this.
Add update-license subcommand to the pr-tool. It will be called automatically when merging a PR.
moved LICENSE.template to devtools/template/LICENSE.txt to prevent that Github displays 2 licenses. Also added a check to prevent manual modifications of LICENSE.txt.
93f887b
to
f6bee17
Compare
Thank you for contributing to the Bareos Project!
Add update-license subcommand to the pr-tool.
It will be called automatically when merging a PR.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Required documentation changes are present and part of the PR