Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-tool: update LICENSE.txt #1773

Merged

Conversation

joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Apr 16, 2024

Thank you for contributing to the Bareos Project!

Add update-license subcommand to the pr-tool.
It will be called automatically when merging a PR.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@joergsteffens joergsteffens force-pushed the dev/joergs/master/updatelicense branch from fd2aadd to b4b0bb6 Compare April 16, 2024 13:49
@joergsteffens joergsteffens added this to the 24.0.0 milestone Apr 16, 2024
@joergsteffens joergsteffens marked this pull request as ready for review April 16, 2024 13:52
@joergsteffens joergsteffens force-pushed the dev/joergs/master/updatelicense branch from b4b0bb6 to f7b5eb8 Compare April 17, 2024 07:26
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor issues with the copyright headers.
Besides that there is a small performance gain possible by omitting an API request and pylint brought up a few remarks.

devtools/pip-tools/license_utils/__init__.py Show resolved Hide resolved
devtools/pip-tools/license_utils/update_license.py Outdated Show resolved Hide resolved
devtools/pip-tools/pr_tool/main.py Outdated Show resolved Hide resolved
devtools/pip-tools/license_utils/__init__.py Outdated Show resolved Hide resolved
devtools/pip-tools/setup.py Show resolved Hide resolved
@joergsteffens joergsteffens marked this pull request as draft May 8, 2024 13:22
@joergsteffens
Copy link
Member Author

I just discovered. that github now has 2 License entries. I assume, one for LICENSE.txt and on for LICENSE.template (https://github.com/bareos/bareos?tab=License-2-ov-file).
I assume, it is best, if I move the tempate file to another directory or rename the file.

@joergsteffens joergsteffens force-pushed the dev/joergs/master/updatelicense branch from a43dcfa to 9481e89 Compare May 8, 2024 17:06
@joergsteffens joergsteffens marked this pull request as ready for review May 8, 2024 17:06
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry for taking so long to finally review this.

joergsteffens and others added 5 commits May 17, 2024 13:25
Add update-license subcommand to the pr-tool.
It will be called automatically when merging a PR.
moved LICENSE.template to devtools/template/LICENSE.txt
to prevent that Github displays 2 licenses.

Also added a check to prevent manual modifications of LICENSE.txt.
@BareosBot BareosBot force-pushed the dev/joergs/master/updatelicense branch from 93f887b to f6bee17 Compare May 17, 2024 13:25
@BareosBot BareosBot merged commit 23b19e6 into bareos:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants