Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add reschedule_job_as_full.sh #1786

Conversation

bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 18, 2024

This helper script aims to help rescheduling incremental plugin job as full level when the plugin detected that incremental failed our would be the size of full level run for example.

fix issue bareos/internal/21

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos added this to the 24.0.0 milestone Apr 18, 2024
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-reschedule_job_as_full.sh-script-to-contrib branch 2 times, most recently from 15df66c to 3fd4273 Compare April 18, 2024 14:24
@arogge arogge requested a review from sduehr April 23, 2024 09:32
@sduehr
Copy link
Member

sduehr commented Apr 29, 2024

I changed the commit description text, it is not because no previous full are found, if that happens, it will be automatically upgraded to full anyway, before any plugin is involved. This script is helpful when only the plugin can detect that a full is required instead of incremental. Could you please change the commit message text accordingly?

Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I suggested some changes.

contrib/misc/reschedule_job_as_full/README.md Outdated Show resolved Hide resolved
contrib/misc/reschedule_job_as_full/README.md Outdated Show resolved Hide resolved
This helper script aims to help rescheduling incremental plugin
job as full level when the plugin detected that incremental failed
our would be the size of full level run for example.

fix issue bareos/internal bareos#21

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: sduehr <stephan.duehr@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/add-reschedule_job_as_full.sh-script-to-contrib branch from 475fa5d to 3b27b6a Compare April 30, 2024 11:38
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good now.

@BareosBot BareosBot merged commit 5037b21 into bareos:master Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants