Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added network sequence diagrams for verify job #215

Merged
merged 1 commit into from Jul 10, 2019
Merged

docs: added network sequence diagrams for verify job #215

merged 1 commit into from Jul 10, 2019

Conversation

franku
Copy link
Contributor

@franku franku commented Jul 9, 2019

  • short and detailed view

@franku franku requested a review from arogge July 9, 2019 13:02
@franku franku force-pushed the dev/franku/master/network-diagrams branch from 82765e2 to d19b716 Compare July 9, 2019 13:06
arogge
arogge requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the diagrams itself look great "Verify single file" is not a sufficient description as we have several different kinds of verify jobs.

@franku franku force-pushed the dev/franku/master/network-diagrams branch from d19b716 to a1ae2d7 Compare July 10, 2019 15:26
@franku
Copy link
Contributor Author

franku commented Jul 10, 2019

Added "Mode: Volume to Catalog"

@franku franku merged commit 9798577 into master Jul 10, 2019
@franku franku deleted the dev/franku/master/network-diagrams branch July 19, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arogge arogge arogge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franku @arogge