Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: replace crc32 implementation #246

Merged
merged 5 commits into from Aug 28, 2019
Merged

Conversation

arogge
Copy link
Member

@arogge arogge commented Aug 21, 2019

The previous crc32 implementation was not optimal from a performance
point-of-view.
This patch introduces Stephan Brumme's Fast CRC32 which is a lot faster
than the old algorithm.

The previous crc32 implementation was not optimal from a performance
point-of-view.
This patch introduces Stephan Brumme's Fast CRC32 which is a lot faster
than the old algorithm.
@arogge arogge requested review from franku and pstorz and removed request for franku August 21, 2019 09:37
@arogge
Copy link
Member Author

arogge commented Aug 21, 2019

I'm not sure the files are in the right location. Can somebody please review?

@arogge arogge requested a review from franku August 21, 2019 10:15
@joergsteffens
Copy link
Member

@arogge
Copy link
Member Author

arogge commented Aug 21, 2019

Licensing info will be added once we've finally agreed on the file locations, because the paths to the sources will be coded into the licensing info.

Copy link
Contributor

@franku franku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, however I would suggest to take only the source code and header files and not the Makefile because we do not use it.

core/src/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@arogge arogge marked this pull request as ready for review August 22, 2019 11:15
@arogge arogge requested a review from franku August 22, 2019 11:15
@stbrumme
Copy link

Hi, I'm the author of the CRC32 library.
My lib uses the zlib license (see https://github.com/stbrumme/crc32/blob/master/LICENSE ).
Quoting from the license: "an acknowledgment in the product documentation would be appreciated but is not required".

Have a nice day,
Stephan

@arogge arogge self-assigned this Aug 26, 2019
@franku franku merged commit beac60c into master Aug 28, 2019
@franku franku deleted the dev/arogge/master/newcrc32 branch August 28, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants