New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: replace crc32 implementation #246
Conversation
The previous crc32 implementation was not optimal from a performance point-of-view. This patch introduces Stephan Brumme's Fast CRC32 which is a lot faster than the old algorithm.
I'm not sure the files are in the right location. Can somebody please review? |
Additional licenses must also be described in https://github.com/bareos/bareos/blob/master/core/LICENSE and https://github.com/bareos/bareos/blob/master/core/debian/copyright.footer |
Licensing info will be added once we've finally agreed on the file locations, because the paths to the sources will be coded into the licensing info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, however I would suggest to take only the source code and header files and not the Makefile because we do not use it.
- remove unneeded files - rename files to match our naming standards
Hi, I'm the author of the CRC32 library. Have a nice day, |
The previous crc32 implementation was not optimal from a performance
point-of-view.
This patch introduces Stephan Brumme's Fast CRC32 which is a lot faster
than the old algorithm.