Fix ordering of rpcgen #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bareos#1058: 18.2.6 build error while cmake don't build the correct dependency's previously rpcgen was called using add_custom_command in PRE_BUILD mode. That mode doesn't work reliably. We now generate files that the bareosndmp target can depend on. This should get the build ordering right every time.
Both director and sd need their static object libraries linked to bareosndmp so the include directory is propagated correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rpcgen was called using add_custom_command in PRE_BUILD
mode. That mode doesn't work reliably.
We now generate files that the bareosndmp target can depend on. This
should get the build ordering right every time.
This PR also disables in-source builds so we don't need to consider in-source builds when running rpcgen.