breg: fix crash when setting regexwhere #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When manually setting the regular expression during restore like with: OK to run? (yes/mod/no): mod ->11: File Relocation ->4: Enter a regexp ->Please enter a valid regexp (!from!to!): !what!with! ->6: Use this ? The director crashed. This happens because the member regex_t preg of the class BareosRegex was not zero initialized correctly. This caused the freeing of random memory in void regfree(regex_t* preg). Now all members of class BareosRegex are zero initialized and the problem is fixed. This problem also causes the filedaemon to crash when regexwhere is specified in the restore job configuration. On the second restore run the filedaemon crashes. Fixes# 1211: bareos director and bareos fd crash when regexwhere is specified
franku
approved these changes
Mar 16, 2020
franku
force-pushed
the
dev/pstorz/master/fix-regexwhere-crash
branch
from
312da09
to
03c53d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually setting the regular expression during restore like with:
OK to run? (yes/mod/no): mod
->11: File Relocation
->4: Enter a regexp
->Please enter a valid regexp (!from!to!): !what!with!
->6: Use this ?
The director crashed. This happens because the member regex_t preg of
the class BareosRegex was not zero initialized correctly.
This caused the freeing of random memory in void regfree(regex_t* preg).
Now all members of class BareosRegex are zero initialized and the
problem is fixed.
This problem also causes the filedaemon to crash when regexwhere is specified
in the restore job configuration. On the second restore run the filedaemon
crashes.
Fixes# 1211: bareos director and bareos fd crash when regexwhere is specified