Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the VirtualFull run job #518

Merged

Conversation

tikoflano
Copy link
Contributor

@tikoflano tikoflano commented May 13, 2020

Based on this #508 (comment)

Now you can select a NextPool value for your VirtualFull Backup, Copy or Migrate job. It considers this:

  • If the Type is Backup:

    • If the selected Level is other than VirtualFull, the Next Pool field will be hidden and empty.
    • If the selected Level is VirtualFull, the Next Pool field will shown and populated with the Next Pool of the currently selected pool if it is defined, empty otherwise.
    • If the selected Pool changes and the Level is VirtualFull, the Next Pool field will be updated to the next pool for the recently selected pool if it is defined, keep the one currently selected otherwise.
    • If the selected Pool changes and the Level is not VirtualFull, it does nothing.
  • If the Type is Copy or Migrate:

    • If the selected Pool changes, the Next Pool field will be updated to the next pool for the recently selected pool if it is defined, keep the one currently selected otherwise.

@tikoflano tikoflano marked this pull request as ready for review May 13, 2020 22:17
@fbergkemper fbergkemper self-requested a review May 27, 2020 08:40
@fbergkemper
Copy link
Contributor

Thank you for the PR. Following are a few change requests.

  • Please drop the merge message 56c16f9.

  • Please combine all commits into one here and change the commit message subject to something like "webui: add next pool selection to custom job run form". Also put in something like your first PR comment in the commit description.

Other than that it seems good. Going to have a second look after cleanup is done.

@fbergkemper
Copy link
Contributor

Hello Alvaro,

will you implement the proposed changes? We would like to merge the PR soon. If there is currently no time available at yours, please give us a short feedback, then we will take care of the changes to the PR ourselves and merge them afterwards.

Regards,
Frank

@tikoflano tikoflano force-pushed the run-job-virtualfull-improvements branch from cf6afe2 to 0a65641 Compare June 11, 2020 05:58
@tikoflano
Copy link
Contributor Author

Please confirm me if I'm doing this rebase thing correctly.

@fbergkemper
Copy link
Contributor

Please confirm me if I'm doing this rebase thing correctly.

You did, thank you.

Copy link
Contributor

@fbergkemper fbergkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, can be merged.

@fbergkemper fbergkemper merged commit a59af84 into bareos:master Jun 15, 2020
@tikoflano tikoflano deleted the run-job-virtualfull-improvements branch June 15, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants