Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicolumn prompts in selection mode #731

Merged
merged 2 commits into from May 27, 2021
Merged

Multicolumn prompts in selection mode #731

merged 2 commits into from May 27, 2021

Conversation

alaaeddineelamri
Copy link
Contributor

No description provided.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch from 0e2ac88 to f93440a Compare February 15, 2021 15:59
franku
franku reviewed Feb 15, 2021
View reviewed changes
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
franku
franku reviewed Feb 15, 2021
View reviewed changes
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 2 times, most recently from 7e3c883 to 9ab3e59 Compare February 18, 2021 08:50
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 7 times, most recently from 6502de0 to 0a025cd Compare March 1, 2021 16:26
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 4 times, most recently from 384aec8 to 2a32b66 Compare March 10, 2021 09:21
@arogge arogge self-assigned this Mar 11, 2021
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 3 times, most recently from fbb74b1 to 8cbdecc Compare March 17, 2021 16:37
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch from 8cbdecc to 5518c4e Compare March 24, 2021 14:10
arogge
arogge requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it out and it is really great!
However, I cannot make it use up all of the 80 text-columns. This should be improved.
Also I have some minor remarks on the code itself.

core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.h Outdated Show resolved Hide resolved
pstorz
pstorz reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the file "muldicolumn_prompts.cc" is new, only our Bareos GmbH Copyright applies here.

core/src/tests/multicolumn_prompts.cc Outdated Show resolved Hide resolved
core/src/tests/multicolumn_prompts.cc Outdated Show resolved Hide resolved
core/src/tests/multicolumn_prompts.cc Outdated Show resolved Hide resolved
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 3 times, most recently from 6db95d0 to 92c5dd6 Compare April 6, 2021 10:56
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 3 times, most recently from 303a275 to 761df91 Compare April 15, 2021 11:35
arogge
arogge reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides a trivial rename and a clarification of @franku's previous comment, the code looks great.

core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.cc Outdated Show resolved Hide resolved
core/src/dird/ua_select.h Outdated Show resolved Hide resolved
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 4 times, most recently from 6d5419b to e47ffb2 Compare April 26, 2021 13:08
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch from e47ffb2 to 0af38f8 Compare April 27, 2021 12:19
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review April 29, 2021 09:12
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 4 times, most recently from 9e72524 to c2d9333 Compare May 7, 2021 09:04
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 2 times, most recently from cb27d63 to 6d888d6 Compare May 14, 2021 10:43
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaa/master/multicolumn-prompts branch 2 times, most recently from b470c0d to a53ab41 Compare May 27, 2021 12:33
@arogge arogge self-requested a review May 27, 2021 15:07
@alaaeddineelamri @arogge
dir: added multi column prompts to selection
5b1ff7f 
- bconsole now shows selection options in multiple columns for
  selections of more than 20 options
@alaaeddineelamri @arogge
updated CHANGELOG
2ce4dfa
@arogge arogge force-pushed the dev/alaa/master/multicolumn-prompts branch from a53ab41 to 2ce4dfa Compare May 27, 2021 15:13
arogge
arogge approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you!
I ran bareos-check-sources and it fixed 3 minor things. I also wrapped a long line in your commit message.

@arogge arogge merged commit 13e8237 into bareos:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstorz pstorz pstorz left review comments

@franku franku franku left review comments

@arogge arogge arogge approved these changes

Assignees

@arogge arogge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alaaeddineelamri @pstorz @franku @arogge