Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to documentation and bconsole typo #86

Merged
merged 1 commit into from
May 29, 2018
Merged

Fix link to documentation and bconsole typo #86

merged 1 commit into from
May 29, 2018

Conversation

thraizz
Copy link
Contributor

@thraizz thraizz commented May 3, 2018

First commit fixes #727: wrong error message in disable schedule
Description: Disabling a non-existent schedule over bconsole no longer
throws "Client not found" error, now it is "Schedule not found"

Second commit fixes a documentation link mentioned here, where a fuzzy directory structure would throw a non-existent link.

@joergsteffens
Copy link
Member

The second patch is not required. The existing link works now.

The first patch is good, but please adapt the commit message to common practice.

@thraizz
Copy link
Contributor Author

thraizz commented May 7, 2018

Done, sorry for the delay. Also rewrote the commit message so that the fix is more obvious.

@joergsteffens
Copy link
Member

Unfortunately, this commit message is still not like requested.
If this references a https://bugs.bareos.org ticket, it should look like:

    bugfix: prevents file corruptions by SHA1
    
    Fixes a bug when using SHA1 file signatures in Bareos version compiled
    without openssl.
    
    Fixes #838: File corruption with SHA1 signature

This way, the bug in https://bugs.bareos.org is automatically closed and refers to the change.

Please adapt your commit message.

As the source have been moved to the core subdirectory, please rebase your commit onto master.

This fixes the error message when disabling a non-existent schedule
from "Client %s not found." to "Schedule %s not found.".

Fixes #727: wrong error message in disable schedule
@thraizz
Copy link
Contributor Author

thraizz commented May 17, 2018

I rebased and changed both the commit message as well as the bugfix itself, so that it matches the new style how error messages are written in ua_cmds.cc.

@joergsteffens joergsteffens merged commit e75bbbf into bareos:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants